refactor(block-kit): inline BlockCompositions calls in actions example - #74
Draft
zimeg wants to merge 1 commit into
Draft
refactor(block-kit): inline BlockCompositions calls in actions example#74zimeg wants to merge 1 commit into
zimeg wants to merge 1 commit into
Conversation
The actions block example mixed a static import of plainText with fully-qualified BlockCompositions.plainText calls in the same file. Because these examples are surfaced in docs.slack.dev as focused snippets (only the exampleNN() body is shown — the imports are not visible to the reader), a bare plainText(...) reads as an unattributed free function. Drop the static import and qualify the remaining calls so every helper in the surfaced range names its class (BlockCompositions.plainText, BlockElements.button, Blocks.actions) — self-contained and consistent. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
This was referenced Sep 1, 2026
zimeg
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Inline the
BlockCompositionshelper calls in the actions block example (blocks/Actions.java) — drop theimport static ...BlockCompositions.plainText;and qualify every call asBlockCompositions.plainText(...).Why
These examples are surfaced on docs.slack.dev as focused snippets — the docs
referenceblock pins only theexampleNN()body, so the static imports at the top of the file are never shown to the reader. A bareplainText(...)in the surfaced range reads as an unattributed free function.Qualifying the calls makes each surfaced snippet self-attributing (
BlockCompositions.plainText(...)), consistent with how the siblingBlocks.*/BlockElements.*calls already name their class.Purely cosmetic — no payload or behavior change.
Scope
Just
blocks/Actions.java(13 calls now qualified). Kept separate from the composition-object and element example inlining so each is a small, reviewable diff.Verified
mvn spotless:check compile→ BUILD SUCCESSblocks/Actions.java🤖 Generated with Claude Code